Allow disabling IPv6 #751
Closed
Allow disabling IPv6 #751
+35
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IDisposable
force-pushed
the
feature/disable-ipv6
branch
2 times, most recently
from
a67f641 to
fb2ae84
Compare
Simply ignores any IPv6 addresses in the lease and doesn't offer them to the RPC Also fixed display issue for IPv6 link local address. Fixes https://github.com/orgs/jetkvm/projects/7/views/1?pane=issue&itemId=122761546&issue=jetkvm%7Ckvm%7C685
IDisposable
force-pushed
the
feature/disable-ipv6
branch
from
fb2ae84 to
a4e0367
Compare
|
Rebased and resolved conflicts |
|
Yep, would be best. I wasn't really sure of the scope of this change and saw the other one in flight. |
|
@adamshiervani I cleaned this code up a lot, perhaps it's good enough to ship now? |
|
(I can't reopen, and the PR is not updating :( ) started a new one at #803 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply ignores any IPv6 addresses in the lease and doesn't offer them to the RPC
Fixes #685